Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set off daemon for entire app #731

Merged
merged 5 commits into from
Dec 17, 2024
Merged

chore: set off daemon for entire app #731

merged 5 commits into from
Dec 17, 2024

Conversation

PatrykKuniczak
Copy link
Collaborator

* Please fill in the required items.

Priority*

  • High: This PR needs to be merged first for other tasks.
  • Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

I've wanted to resolve issue with deleting .turbo and this resolve it and also improve performance, because of:
vercel/turborepo#8122
On some machines

Changes*

I've added "daemon": true to turbo.json and remove daemon stop from clean scripts

How to check the feature

run e.g. pnpm dev, then stop script and try to run pnpm clean:turbo and check it works without any permission error

turbo.json Show resolved Hide resolved
@PatrykKuniczak
Copy link
Collaborator Author

PatrykKuniczak commented Dec 17, 2024

@Jonghakseo What's with this?

It will fix also: #696

Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonghakseo Jonghakseo enabled auto-merge (squash) December 17, 2024 11:54
@Jonghakseo Jonghakseo disabled auto-merge December 17, 2024 11:54
@Jonghakseo Jonghakseo enabled auto-merge (squash) December 17, 2024 11:55
@Jonghakseo Jonghakseo merged commit e9cc9b2 into main Dec 17, 2024
7 checks passed
@Jonghakseo Jonghakseo deleted the chore/set-off-daemon branch December 17, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants